-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #7231 Update base.css #7301
Conversation
Updating to limit max width of inner windowed panel
Sorry, I forgot to add a PR label. As the description states this is related to issue 7231 |
Thanks @v-lozko for working on this. Would you be able to add a screenshot to the top comment so it's easier to have an idea of the fix? |
Updated the top comment |
I realized didn't actually take a screenshot of the actual notebook above. In any case, it seems to work appropriately when resizing it in both full and defer mode. It looks like its just a bit too wide. seems like only 693 pixels differ and some of those are the icons, and the height is 68.6px, so must be only a few pixels off on width. I set it to that variable because it seemed most appropriate. What should be the next steps forward then to resolve this? |
Thanks @v-lozko. I think we can trigger a snapshot update to fix the UI tests, and the PR should be ready to go. |
bot please update playwright snapshots |
Ah now that JupyterLab 4.2.0b0 is released and defaults to the |
Awesome, thanks! |
Updating to limit max width of inner windowed panel. Inner panel was extending past screen on right.
Added a max-width to the innerWindowedPanel as it was extending past 1200 px when window was larger than that.
Here is screenshot of notebook in binder